feat: add per-IP rate limiting to /register and /federation - #626
Merged
Abdulazeem-code merged 1 commit intoAug 29, 2026
Merged
Conversation
Apply a dedicated rate limiter (100 requests / 15 min per IP) to the /register and /federation endpoints, returning 429 when exceeded. This protects against spam and brute-force that could otherwise bypass the account-keyed global limiter by rotating addresses.
|
@devprom6 is attempting to deploy a commit to the Abdulazeem's projects Team on Vercel. A member of the Team first needs to authorize it. |
|
@devprom6 Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes #252
Protect the API from spam and brute-force attacks by limiting requests per IP.
A dedicated
ipLimiteris added instellar-payment-platform/server.jsthat caps clients at 100 requests per 15 minutes per IP and responds with 429 Too Many Requests when the limit is exceeded. It is applied directly to the/registerand/federationendpoints.Unlike the existing global limiter (which keys by account id and can be bypassed by rotating addresses in the payload), this limiter keys strictly by client IP, so a single source flooding the endpoints is reliably blocked.
Changes
ipLimiter(windowMs: 15 * 60 * 1000, max: 100) keyed by client IP, returning aRATE_LIMITEDerror body on exceed.RedisStorewhen available, with in-memory fallback.ipLimiteras the first middleware on:app.post('/register', ...)app.get('/federation', ...)Acceptance Criteria
Notes
express-rate-limitandrate-limit-rediswere already declared instellar-payment-platform/package.json.Test Plan
/registerand/federationfrom the same IP within 15 minutes and confirm a 429 response with aRATE_LIMITEDbody.RateLimit-*headers are present on responses.